mreutegg commented on code in PR #250:
URL:
https://github.com/apache/jackrabbit-filevault/pull/250#discussion_r991868319
##########
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/registry/impl/JcrPackageRegistry.java:
##########
@@ -655,8 +655,8 @@ public void remove(@NotNull PackageId id) throws
IOException, NoSuchPackageExcep
if (pkg == null) {
throw new NoSuchPackageException().setId(id);
}
- JcrPackage pack = pkg.getJcrPackage();
try {
+ JcrPackage pack = pkg.getJcrPackage();
Review Comment:
Ah, missed that one. Though, it seems it is not necessary in this case.
Closing `JcrRegisteredPackage` already closes the `JcrPackage` it holds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
