lweitzendorf commented on code in PR #692:
URL: https://github.com/apache/jackrabbit-oak/pull/692#discussion_r995418228
##########
oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/FileStore.java:
##########
@@ -198,7 +192,7 @@ private static GarbageCollectionStrategy
newGarbageCollectionStrategy() {
defaultSegmentWriterBuilder("c")
.with(builder.getCacheManager().withAccessTracking("COMPACT", statsProvider))
.withGeneration(generation)
- .withoutWriterPool()
+
.withWriterPool(SegmentBufferWriterPool.PoolType.THREAD_SPECIFIC)
Review Comment:
A single `SegmentBufferWriter`, which is used if there is no writer pool, is
not thread-safe and a writer pool for a single thread behaves the same as a
`SegmentBufferWriter` and should only have minimal overhead with the
thread-specific implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
