fabriziofortino commented on code in PR #743:
URL: https://github.com/apache/jackrabbit-oak/pull/743#discussion_r1014097607
##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/async/ElasticResultRowAsyncIterator.java:
##########
@@ -253,9 +252,8 @@ class ElasticQueryScanner {
}
);
- if (LOG.isTraceEnabled()) {
- LOG.trace("Kicking initial search for query {}",
ElasticIndexUtils.toString(searchReq));
- }
+
+ LOG.trace("Kicking initial search for query {}", searchReq);
Review Comment:
that's not needed anymore. Before this change, we had to create the `String`
representation because the Elasticsearch client did not return it. The behavior
has been fixed with the latest client (updated before this PR). I have removed
the if-block because we pass the SearchRequest object reference now. Log4j does
not call the toString except when the log level is >= TRACE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
