reschke commented on code in PR #745:
URL: https://github.com/apache/jackrabbit-oak/pull/745#discussion_r1015333246


##########
oak-run-commons/src/test/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileSplitterTest.java:
##########
@@ -533,4 +548,15 @@ public void uncompress(File src, File dest) throws 
IOException {
             }
         }
     }
+    
+    private static Set<String> readAllFilesAsSet(List<File> files) {
+        Set<String> set = files.stream().flatMap(file -> {
+            try ( InputStream is = Files.newInputStream(file.toPath())) {

Review Comment:
   Hm. My main concern is not leftover files from tests, but unclosed files in 
general. These may not manifest themselves as leftover files on non-Windows 
systems, but would still be a problem in production.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to