jelmini commented on code in PR #800:
URL: https://github.com/apache/jackrabbit-oak/pull/800#discussion_r1052435064


##########
oak-segment-remote/src/main/java/org/apache/jackrabbit/oak/segment/remote/AbstractRemoteSegmentArchiveWriter.java:
##########
@@ -150,6 +150,12 @@ public void flush() throws IOException {
         }
     }
 
+    @Override
+    public void flush(Runnable callback) throws IOException {

Review Comment:
   I would use here the same parameter name `onSuccess` than in the interface, 
instead of `callback`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to