stefan-egli commented on code in PR #863:
URL: https://github.com/apache/jackrabbit-oak/pull/863#discussion_r1122127226
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java:
##########
@@ -1350,6 +1358,10 @@ private <T extends Document> BulkUpdateResult
sendBulkUpdate(Collection<T> colle
int i = 0;
for (UpdateOp updateOp : updateOps) {
String id = updateOp.getId();
+ int size = updateOp.toString().length();
Review Comment:
Is updateOp the right way to measure this though? Isn't that a generic
documentMk side object and what mongo sees is the Bson query below?
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java:
##########
@@ -157,6 +157,10 @@ public class MongoDocumentStore implements DocumentStore {
*/
public static final long DEFAULT_THROTTLING_TIME_MS =
Long.getLong("oak.mongo.throttlingTime", 20);
+ /**
+ * Document size of 16MB is a limit in Mongo
+ */
+ public static final long SIZE_LIMIT = 16793600;
Review Comment:
This is a bit larger than 16MB, what's the reason? I was also wondering
whether we shouldn't warn below 16MB already to have some buffer, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
