fabriziofortino commented on code in PR #860:
URL: https://github.com/apache/jackrabbit-oak/pull/860#discussion_r1127674784
##########
oak-search-elastic/src/test/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticFullTextIndexCommonTest.java:
##########
@@ -67,4 +72,27 @@ protected List<String> getExpectedLogMessage() {
expectedLogList.add(log2);
return expectedLogList;
}
+
+ @Test
+ /*
+ * analyzers by name are not possible in lucene, this test can run on
elastic only
+ */
+ public void fulltextSearchWithBuiltInAnalyzerName() throws Exception {
+ setup(singletonList("foo"), idx -> {
+ Tree anl =
idx.addChild(FulltextIndexConstants.ANALYZERS).addChild(FulltextIndexConstants.ANL_DEFAULT);
+ anl.setProperty(FulltextIndexConstants.ANL_NAME, "german");
Review Comment:
That's not supported in Lucene. Analyzers need to be fully qualified class
names. Since this is possible in Elastic, I think it is right to have a test
here only. I don't see the point of having the same test in Lucene that
verifies that an Exception gets thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
