reschke commented on code in PR #279:
URL: 
https://github.com/apache/jackrabbit-filevault/pull/279#discussion_r1128281867


##########
vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageDefinitionImpl.java:
##########
@@ -646,6 +646,13 @@ public String getCreatedBy() {
         return get(PN_CREATED_BY);
     }
 
+    /**
+     * {@inheritDoc}
+     */
+    public String getGenerator() {

Review Comment:
   Not convinced. I agree that "@Override" is better, but shouldn't we do this 
consistently here? Any way, your choice, just let me know.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to