rishabhdaim commented on code in PR #847:
URL: https://github.com/apache/jackrabbit-oak/pull/847#discussion_r1129194742
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/indexversion/IndexVersionOperation.java:
##########
@@ -254,6 +242,24 @@ enum Operation {
DELETE_HIDDEN_AND_DISABLE,
DELETE
}
+
+ protected abstract IndexVersionOperation
getIndexVersionOperationInstance(IndexName indexName);
+
+ /**
+ *
+ * @param indexNode - NodeState of a disabled index
+ * @return true if the disabled index with NodeState indexNode can be
marked for deletion or not.
+ */
+ protected abstract boolean
checkIfDisabledIndexCanBeMarkedForDeletion(NodeState indexNode);
+
+ /**
+ *
+ * @param reverseSortedIndexNameList
+ * @param parentPath
+ * @param rootNode
+ * @return Highest versioned active index's IndexName
+ */
+ protected abstract IndexName getActiveIndex(List<IndexName>
reverseSortedIndexNameList, String parentPath, NodeState rootNode);
Review Comment:
This method should be annotated with `@Nullable` since it can return a null
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
