kwin commented on code in PR #293:
URL:
https://github.com/apache/jackrabbit-filevault/pull/293#discussion_r1180171286
##########
vault-core/src/test/java/org/apache/jackrabbit/vault/packaging/integration/PrincipalBasedIT.java:
##########
@@ -201,6 +206,24 @@ private void assertPolicy(@NotNull Principal principal,
@NotNull AccessControlEn
fail("expected PrincipalAccessControlList for principal " +
principal.getName());
}
+ @Test
+ public void testEntriesFromSetup() throws AccessDeniedException,
AccessControlException, UnsupportedRepositoryOperationException,
RepositoryException {
+ @NotNull
+ JackrabbitAccessControlPolicy[] applicablePolicies =
acMgr.getApplicablePolicies(testUser.getPrincipal());
+ // for some reason only 1 is returned and no longer 2 as in the setUp
method
+ assertEquals(1, applicablePolicies.length);
Review Comment:
Nevermind, was a misunderstanding of `getApplicablePolicies` vs
`getPolicies`. I will try to improve the javadocs in that regard in
https://github.com/apache/jackrabbit-oak/blob/d25263450748fde7fd72923b5253cf637794886c/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/security/JackrabbitAccessControlManager.java#L48.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
