mreutegg commented on code in PR #863: URL: https://github.com/apache/jackrabbit-oak/pull/863#discussion_r1185993139
########## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java: ########## @@ -1470,8 +1487,18 @@ public <T extends Document> boolean create(Collection<T> collection, List<Update } insertSuccess = true; return true; - } catch (MongoException e) { - return false; + } catch (BsonMaximumSizeExceededException e) { + T doct = null; + for (T doc : docs) { + doct = doc; + // doc.getMemory()/2 - converting from UTF-16 to UTF-8 + if (doc.getMemory()/2 > SIZE_LIMIT) { Review Comment: How about removing this somewhat arbitrary threshold and simply log memory usage for each document? At this point we know some Bson size exceeded the limit. Readers of the log message can then interpret which document was most likely the culprit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org