rishabhdaim commented on code in PR #937:
URL: https://github.com/apache/jackrabbit-oak/pull/937#discussion_r1193605021
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/core/MutableRoot.java:
##########
@@ -121,6 +126,8 @@ class MutableRoot implements Root, PermissionAware {
*/
private final MoveTracker moveTracker = new MoveTracker();
+ private final Map<MutableTree, Object> trees = synchronizedMap(new
WeakHashMap<>());
Review Comment:
Shouldn't we use weakSet here, since we are not using `value` from `Map`
```suggestion
private final Set<MutableTree> treeSet = newSetFromMap(new
WeakHashMap<MutableTree, Boolean>());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
