rishabhdaim commented on PR #920: URL: https://github.com/apache/jackrabbit-oak/pull/920#issuecomment-1564292881
Thanks, [Julian Reschke](https://github.com/jira/secure/ViewProfile.jspa?name=reschke) for the feedback. However, I see the following issues with putting the new `findAndUpdate` API into MongoVersionGCSupport: - I don't see it as the right candidate for database-related operations. It's more of a support class for Mongo-related GC ops. - Having an API in the DocumentStore gives us the following advantages: 1. We are sure of the lease check since it will be done automatically for us. We already have an epic to solve issues which are caused by late-writes i.e. writing after the lease had expired. 1. We can take into account throttling as well. I really don't want to perform heavy garbage collection operations if my system is already under heavy load. 1. I can reuse some of the already existing code. 1. We won't miss the stats for those operations which are done inside DocumentStore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
