tihom88 commented on code in PR #991:
URL: https://github.com/apache/jackrabbit-oak/pull/991#discussion_r1238390508
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/IndexerSupport.java:
##########
@@ -121,7 +121,7 @@ public void updateIndexDefinitions(NodeBuilder rootBuilder)
throws IOException,
protected void dumpIndexDefinitions(NodeStore nodeStore) throws
IOException {
IndexDefinitionPrinter printer = new IndexDefinitionPrinter(nodeStore,
indexHelper.getIndexPathService());
- printer.setFilter("{\"properties\":[\"*\",
\"-:childOrder\"],\"nodes\":[\"*\", \"-:index-definition\"]}");
+ printer.setFilter("{\"properties\":[\"*\",
\"-:childOrder\"],\"nodes\":[\"*\", \"-:index-definition\", \"-:data\",
\"-:suggest-data\"]}");
Review Comment:
Hi @thomasmueller ,
Looks like we don't need hidden nodes at all in index-definitions file.
While importing index we do cloneVisibleState from index definition.
https://github.com/apache/jackrabbit-oak/blob/16edc2c0b7a3ab20cfbc2dc04b92a5ed245941dd/oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/ReindexOperations.java#L75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
