thomasmueller commented on code in PR #1012:
URL: https://github.com/apache/jackrabbit-oak/pull/1012#discussion_r1254191855
##########
oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/spi/query/FulltextIndex.java:
##########
@@ -429,7 +429,12 @@ public String next() {
readCount++;
if (readCount % TRAVERSING_WARNING == 0) {
Cursors.checkReadLimit(readCount, settings);
- log.warn("Index-Traversed {} nodes with filter {}",
readCount, plan.getFilter());
+ if (readCount == 2 * TRAVERSING_WARNING) {
Review Comment:
Yes. There will be a warning (without stack trace) at 10'000 nodes read. And
at 20'000, there will be a warning PLUS a stack trace.
> why not print it with the first message
My idea is that 10'000 is kind of OKish... so for those developers that see
the message and fix the problem, the more "severe" stack trace is not listed.
Another reason is that the distribution is right skewed (the median is low),
so this will log less stack traces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
