nfsantos commented on code in PR #1012:
URL: https://github.com/apache/jackrabbit-oak/pull/1012#discussion_r1254203940
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/cursor/TraversingCursor.java:
##########
@@ -159,10 +159,15 @@ private void fetchNext() {
readCount++;
if (readCount % 1000 == 0) {
- FilterIterators.checkReadLimit(readCount, settings);
- String caller =
IndexUtils.getCaller(this.settings.getIgnoredClassNamesInCallTrace());
- LOG.warn("Traversed {} nodes with filter {} called by {};
consider creating an index or changing the query" ,
- readCount, filter, caller);
+ if (readCount == 20000) {
+ LOG.warn("Traversed {} nodes with filter {}; consider
creating an index or changing the query",
+ readCount, filter, new Exception("call
stack"));
Review Comment:
They are being imprecise with the use of the term exception, the method
takes a Throwable as an argument:
https://www.javadoc.io/doc/org.slf4j/slf4j-api/latest/org/slf4j/Logger.html#warn(java.lang.String,java.lang.Throwable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
