kwin commented on code in PR #1014:
URL: https://github.com/apache/jackrabbit-oak/pull/1014#discussion_r1259711992
##########
oak-authorization-principalbased/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/principalbased/impl/FilterProviderImpl.java:
##########
@@ -98,19 +107,23 @@ public Filter getFilter(@NotNull SecurityProvider
securityProvider, @NotNull Roo
//----------------------------------------------------< SCR Integration
>---
+ public FilterProviderImpl() {
+ // constructor to use from SCR (not yet possible to use constructor
injection, see https://issues.apache.org/jira/browse/OAK-9837)
+ }
+
@Activate
- protected void activate(Configuration configuration, Map<String, Object>
properties) {
- setPath(configuration);
+ protected void activate(Configuration configuration) {
Review Comment:
Sorry, I will revert if you insist but will not do the additional overhead
of creating another PR. For me things like these should be fixed along with the
issues. In this case I fail to see risk of regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
