nfsantos commented on PR #1027: URL: https://github.com/apache/jackrabbit-oak/pull/1027#issuecomment-1640037684
Yes, I agree that there should be a maximum bound on the memory size for situations where this is run with very large heaps. I had not considered that case. Ok, I'll make a PR to reduce the minimum size of the memory buffers for cases with low heap and to enforce a reasonable upper limit. I have done performance tests but it is not really clear what are the best settings, depends in many external factors. The auto-detect logic is just to make it work with reasonable performance in any setup without requiring manual configuration of this parameter. I expect that when performance is important, we will define this value explicitly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
