stefan-egli commented on code in PR #1075:
URL: https://github.com/apache/jackrabbit-oak/pull/1075#discussion_r1297337988
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -685,6 +686,9 @@ private void collectDetailedGarbage(final GCPhases phases,
final RevisionVector
modified, fromModifiedMs,
toModifiedMs);
}
}
+ if (infoFullGCEnabled) {
+ return;
Review Comment:
there's a problem here : with returning early, the part of the code after
the `removeGarbage` bit, is not executed. This would mean the iterating logic
would somehow break. I think it would be good to have a test case that proves
it would break, and then fix this bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
