stefan-egli commented on code in PR #1079: URL: https://github.com/apache/jackrabbit-oak/pull/1079#discussion_r1303038509
########## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DetailedRevisionGCStatsCollector.java: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.jackrabbit.oak.plugins.document; + +import org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollector.VersionGCStats; + +/** + * Collector interface for {@link DocumentNodeStore} Detailed revision garbage collection + * statistics. + */ +public interface DetailedRevisionGCStatsCollector { + + void documentRead(); + + void deletedPropertiesRead(long numProps); Review Comment: Do we need this level of granularity? I understand that `documentsUpdated` might not contain the full set of documents we wanted to update, as `findAndUpdate` might fail for some. But I'm wondering if we rather should have a counter for those failures on the document granularity level, rather than deeper (eg deletedPropertiesRead, but also the same for unmerged branch commits and individual revisions). Wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
