steffenvan commented on code in PR #1071: URL: https://github.com/apache/jackrabbit-oak/pull/1071#discussion_r1318718146
########## oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneDocumentMaker.java: ########## @@ -315,6 +313,38 @@ protected boolean indexTypeOrderedFields(Document doc, String pname, int tag, Pr } return fieldAdded; } + + protected static BytesRef checkTruncateLength(String prop, String value, String path, int maxLength) { Review Comment: But if you don't like the refactoring that's okay. I think what's most crucial is that we just document why we are doing those magical things - with some examples as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org