mreutegg commented on code in PR #1051:
URL: https://github.com/apache/jackrabbit-oak/pull/1051#discussion_r1328398490
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/version/VersionEditor.java:
##########
@@ -212,7 +212,7 @@ private boolean isLockProperty(PropertyState state) {
private boolean wasCheckedIn() {
PropertyState prop = before.getProperty(JCR_ISCHECKEDOUT);
if (prop != null) {
- return !prop.getValue(Type.BOOLEAN);
+ return !prop.getValue(Type.BOOLEAN) && isVersionable;
Review Comment:
Why not use `isVersionable()` instead? `isVersionable` can be null and needs
to be computed first. I see calls to wasCheckedIn() are currently always
preceded with isVersionable(), but I'd rather not introduce this implicit
dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
