adamcin commented on PR #314:
URL:
https://github.com/apache/jackrabbit-filevault/pull/314#issuecomment-1745274386
> Looks good, is it possible to have an IT verifying that this doesn't
require particular permissions (apart from read) to prevent regressions here?
I've added an IT, and for the record, here is the result of the IT when I
leave the `determineAuthorizableRootPaths` method in and call it from the
`areAuthorizablesAllowed()` method:
```
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
6.240 s <<< FAILURE! -- in
org.apache.jackrabbit.vault.fs.spi.impl.jcr20.JackrabbitACLManagementIT
[ERROR]
org.apache.jackrabbit.vault.fs.spi.impl.jcr20.JackrabbitACLManagementIT.testReadOnlyPermissionsOverHome
-- Time elapsed: 0.274 s <<< ERROR!
javax.jcr.AccessDeniedException: Access denied.
at
org.apache.jackrabbit.oak.spi.security.authorization.accesscontrol.AbstractAccessControlManager.checkPermissions(AbstractAccessControlManager.java:261)
at
org.apache.jackrabbit.oak.spi.security.authorization.accesscontrol.AbstractAccessControlManager.getTree(AbstractAccessControlManager.java:221)
at
org.apache.jackrabbit.oak.security.authorization.accesscontrol.AccessControlManagerImpl.getApplicablePolicies(AccessControlManagerImpl.java:180)
at
org.apache.jackrabbit.oak.spi.security.user.action.AccessControlAction.setAC(AccessControlAction.java:160)
at
org.apache.jackrabbit.oak.spi.security.user.action.AccessControlAction.onCreate(AccessControlAction.java:123)
at
org.apache.jackrabbit.oak.security.user.UserManagerImpl.onCreate(UserManagerImpl.java:312)
at
org.apache.jackrabbit.oak.security.user.UserManagerImpl.createGroup(UserManagerImpl.java:248)
at
org.apache.jackrabbit.oak.security.user.UserManagerImpl.createGroup(UserManagerImpl.java:232)
at
org.apache.jackrabbit.oak.jcr.delegate.UserManagerDelegator$13.perform(UserManagerDelegator.java:217)
at
org.apache.jackrabbit.oak.jcr.delegate.UserManagerDelegator$13.perform(UserManagerDelegator.java:213)
at
org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:229)
at
org.apache.jackrabbit.oak.jcr.delegate.UserManagerDelegator.createGroup(UserManagerDelegator.java:213)
at
org.apache.jackrabbit.vault.fs.spi.impl.jcr20.JackrabbitACLManagement.determineAuthorizableRootPaths(JackrabbitACLManagement.java:208)
at
org.apache.jackrabbit.vault.fs.spi.impl.jcr20.JackrabbitACLManagement.areAuthorizablesAllowed(JackrabbitACLManagement.java:217)
at
org.apache.jackrabbit.vault.fs.spi.impl.jcr20.JackrabbitACLManagement.getPrincipalAcls(JackrabbitACLManagement.java:224)
at
org.apache.jackrabbit.vault.fs.spi.impl.jcr20.JackrabbitACLManagementIT.testReadOnlyPermissionsOverHome(JackrabbitACLManagementIT.java:48)
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
