amit-jain commented on code in PR #1135:
URL: https://github.com/apache/jackrabbit-oak/pull/1135#discussion_r1348507719
##########
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/ExternalSort.java:
##########
@@ -460,11 +603,20 @@ public static <T> File sortAndSave(List<T> tmplist,
* @param typeToString
* function to map string to custom type. User for coverting line
to custom type for the
* purpose of sorting
+ * @param filterPredicate
Review Comment:
Can we clarify this to say that (filter out comes out as removing to me but
here we negate the keep predicate)
`predicate to keep relevant data which need to be sorted`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
