t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352342828


##########
oak-lucene/pom.xml:
##########
@@ -471,5 +471,11 @@
       <version>1.19.0</version>
       <scope>test</scope>
     </dependency>
+    <dependency>

Review Comment:
   No, testcontainers dependency is defined under dependencyManagment of 
oak-parent. This will not be inherited by the child module until it is 
explicitly defined under dependencies of child module.
   
   Other workaround for this is to define it under the dependencies tag in 
parent pom, in this way it will be available to all the child modules but this 
should not be done since this is not needed by all the child modules



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to