[ 
https://issues.apache.org/jira/browse/JCRVLT-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781408#comment-17781408
 ] 

Konrad Windszus commented on JCRVLT-724:
----------------------------------------

After reading https://issues.apache.org/jira/browse/OAK-10523 I have the 
feeling that we should rather fix the invalid name returned by Oak (in this 
case) in the DocViewNode2, log a warning and convert that into a proper index. 
Reimporting such packages in Oak will fail though as the basic SNS support 
(OAK-203) is read-only but does not allow to create those with JCR API IIUC.

> DocViewSaxFormatter: improve diagnostics when generating DocViewNode2 from 
> JCR node
> -----------------------------------------------------------------------------------
>
>                 Key: JCRVLT-724
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-724
>             Project: Jackrabbit FileVault
>          Issue Type: Task
>          Components: vlt
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Major
>             Fix For: 3.7.2
>
>         Attachments: SameNameSiblingIT.java
>
>
> See 
> <[https://github.com/apache/jackrabbit-filevault/blob/c0480b9f83ede8969d8bcaf03428a35f81d146c2/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewNode2.java#L91-L110]>
> We have the unfortunate condition that an existing repository apparently 
> contains invalid node names. The code above gets an IllegalNameException from 
> {{nameresolver.getQName()}}, but that code doesn't have the full path to the 
> node (well, it shouldn't exist in the first place...).
> It might be good to catch that exception and add information about the node's 
> path and rethrow it, either where or in the calling code 
> ({{AggregateImpl.walk()}}?).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to