thomasmueller commented on code in PR #1215:
URL: https://github.com/apache/jackrabbit-oak/pull/1215#discussion_r1395684061
##########
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LucenePropertyIndex.java:
##########
@@ -1677,6 +1708,28 @@ private List<Facet> getFacetsUncached(int
numberOfFacets, String columnName) thr
indexNode.release();
}
}
+
+ private List<Facet> getFacetsUncached(Facets facets, int
numberOfFacets, String columnName) throws IOException {
Review Comment:
I did this on purpose actually: to keep the old code as is as much as
possible, in case we need to switch back to it. I agree it would be better, but
hopefully we don't need the old code in the future - in which case we should
remove it. I'm fine to create a jira issue about removing the old code in 6
month, so we don't forget. OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
