stefan-egli commented on code in PR #1251:
URL: https://github.com/apache/jackrabbit-oak/pull/1251#discussion_r1429863962
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Checkpoints.java:
##########
@@ -146,8 +146,13 @@ public Revision getOldestRevisionToKeep() {
}
if (op.hasChanges()) {
- store.findAndUpdate(Collection.SETTINGS, op);
- LOG.debug("Purged {} expired checkpoints", op.getChanges().size());
+ try {
+ store.findAndUpdate(Collection.SETTINGS, op);
+ LOG.debug("Purged {} expired checkpoints",
op.getChanges().size());
+ } catch (UnsupportedOperationException uoe) {
+ LOG.info("getOldestRevisionToKeep : could not clean up expired
checkpoints"
Review Comment:
Reason for info was that using this in read-only (eg via oak-run revisions
info), this exception is likely met. In which case a warn would be confusing. I
think we'd need to expose whether or not a DocumentStore is read-only somehow -
without that we're left with catching this exception (which I agree is not nice)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
