mbaedke commented on code in PR #1214:
URL: https://github.com/apache/jackrabbit-oak/pull/1214#discussion_r1469468303


##########
oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/osgi/RepositoryManagerTest.java:
##########
@@ -85,6 +86,7 @@ public void repositoryShutdown() throws Exception{
 
 
     private void registerRequiredServices() {
+        context.registerService(StatisticsProvider.class, 
StatisticsProvider.NOOP);

Review Comment:
   Technically it was a behavioral change, because previously the 
RepositoryManager would start without the reference being fulfilled. In 
practice it probably doesn't make a difference, because e.g. 
org.apache.jackrabbit.oak.plugins.blob.datastore.AbstractDataStoreService 
requires a StatisticsProvider service. Anyway I removed the whole thing, 
because it wasn't being used at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to