rishabhdaim commented on code in PR #1287: URL: https://github.com/apache/jackrabbit-oak/pull/1287#discussion_r1469947019
########## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ########## @@ -153,13 +153,14 @@ public class VersionGarbageCollector { VersionGarbageCollector(DocumentNodeStore nodeStore, VersionGCSupport gcSupport, final boolean detailedGCEnabled, - final boolean isDetailedGCDryRun) { + final boolean isDetailedGCDryRun, + final boolean embeddedVerification) { this.nodeStore = nodeStore; this.versionStore = gcSupport; this.ds = gcSupport.getDocumentStore(); this.detailedGCEnabled = detailedGCEnabled; this.isDetailedGCDryRun = isDetailedGCDryRun; - this.embeddedVerification = true; //TODO: make this "configurable" + this.embeddedVerification = embeddedVerification; //TODO: make this "configurable" for actual detailedGC Review Comment: The only reason, I didn't move this to `DocumentNodeStore` is because of the https://issues.apache.org/jira/browse/OAK-10633 ticket. This ticket would eventually remove this TODO once finished. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org