reschke commented on code in PR #328: URL: https://github.com/apache/jackrabbit-filevault/pull/328#discussion_r1479715212
########## vault-core-it/vault-core-integration-tests/src/main/java/org/apache/jackrabbit/vault/packaging/integration/ReferenceableIdentifiersImportIT.java: ########## @@ -401,6 +422,138 @@ public void testImportDupPolicyLegacy() throws RepositoryException, IOException, assertNull(duplicateNode); } + @Test + public void testInstallPackage_CREATE_NEW_ID() throws Exception { + test(IdConflictPolicy.CREATE_NEW_ID, null, null, true, true); + } + + @Test + public void testInstallPackage_FAIL() throws Exception { + test(IdConflictPolicy.FAIL, RepositoryException.class, null, false, false); + } + + @Test + public void testInstallPackage_FORCE_REMOVE_CONFLICTING_ID() throws Exception { + test(IdConflictPolicy.FORCE_REMOVE_CONFLICTING_ID, null, null, false, false); + } + + @Test + public void testInstallPackage_LEGACY() throws Exception { + test(IdConflictPolicy.LEGACY, RepositoryException.class, IllegalStateException.class, false, false); + } + + private void test(IdConflictPolicy policy, Class<?> expectedException, Class<?> expectedRootCause, boolean expectNewId, Review Comment: Yep. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org