stefan-egli commented on PR #1288: URL: https://github.com/apache/jackrabbit-oak/pull/1288#issuecomment-1933923724
@Joscorbe , @rishabhdaim , @reschke , @mbaedke , I'd like to do a vote on the different options discussed in this OAK-10281 PR - namely: Trying to summarize the current options: 1. https://github.com/apache/jackrabbit-oak/pull/1288 : `static` 2. https://github.com/apache/jackrabbit-oak/pull/1292 : `DocumentStore.getRecoveryDelayMillis` 3. https://github.com/apache/jackrabbit-oak/pull/1301 : a new one that Rishabh suggested offline: `isRecoveryNeeded` requiring a 2nd parameter `recoveryDelayMillis` directly 4. (similar to https://github.com/apache/jackrabbit-oak/pull/1288) : `static` (like 1.) but add a loud disclaimer that this should be cleaned up - ie create a technical debt ticket to look into a more broader refactoring that also includes similar other cases such as the static `clock` for example. Please vote / comment, thx! My vote : 1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
