reschke commented on code in PR #1300:
URL: https://github.com/apache/jackrabbit-oak/pull/1300#discussion_r1484101720
##########
oak-core-spi/src/main/java/org/apache/jackrabbit/oak/spi/nodetype/EffectiveNodeTypeProvider.java:
##########
@@ -83,8 +84,26 @@ default boolean isNodeType(@NotNull String primaryTypeName,
@NotNull Iterator<St
* refer to an existing node type.
* @throws RepositoryException If the given node type name is invalid or if
* some other error occurs.
+ * @deprecated use {@link #isNodeType(String, Supplier, String)} instead
*/
- boolean isNodeType(@NotNull String primaryTypeName, @NotNull
Iterable<String> mixinTypes, @NotNull String nodeTypeName) throws
NoSuchNodeTypeException, RepositoryException;
+ default boolean isNodeType(@NotNull String primaryTypeName, @NotNull
Iterable<String> mixinTypes, @NotNull String nodeTypeName) throws
NoSuchNodeTypeException, RepositoryException {
+ return isNodeType(primaryTypeName,() -> mixinTypes, nodeTypeName);
Review Comment:
```suggestion
return isNodeType(primaryTypeName, () -> mixinTypes, nodeTypeName);
```
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/ReadOnlyNodeTypeManager.java:
##########
@@ -283,8 +284,7 @@ public boolean isNodeType(@NotNull Tree tree, @NotNull
String oakNtName) {
return false;
}
- @Override
- public boolean isNodeType(@Nullable String primaryTypeName, @NotNull
Iterable<String> mixinTypes, @NotNull String nodeTypeName) {
+ public boolean isNodeType(@Nullable String primaryTypeName, @NotNull
Supplier<Iterable<String>> mixinTypes, @NotNull String nodeTypeName) {
Review Comment:
@Override missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
