fabriziofortino commented on code in PR #1354:
URL: https://github.com/apache/jackrabbit-oak/pull/1354#discussion_r1517508714
##########
oak-run/src/test/java/org/apache/jackrabbit/oak/index/IncrementalStoreTest.java:
##########
@@ -126,20 +142,34 @@ public void tear() {
@Test
public void testWithNoCompression() throws Exception {
- algorithm = Compression.NONE;
- incrementalFFSTest();
+ System.setProperty(OAK_INDEXER_USE_ZIP, "false");
+ algorithm = IndexStoreUtils.compressionAlgorithm();
+ incrementalFFSTest(false);
+ System.clearProperty(OAK_INDEXER_USE_ZIP);
}
@Test
public void testWithGzipCompression() throws Exception {
- algorithm = Compression.GZIP;
- incrementalFFSTest();
+ // LZ4 compression is used by default - so disbale that, fallback is
gzip
Review Comment:
typo
```suggestion
// LZ4 compression is used by default - so disable that, fallback is
gzip
```
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/IndexerSupport.java:
##########
@@ -29,7 +29,10 @@
import org.apache.commons.io.FileUtils;
import org.apache.felix.inventory.Format;
-import org.apache.jackrabbit.guava.common.base.Predicate;
+import java.util.function.Predicate;
+import java.util.regex.Matcher;
Review Comment:
unused import
```suggestion
import java.util.regex.Matcher;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
