kwin commented on code in PR #1352:
URL: https://github.com/apache/jackrabbit-oak/pull/1352#discussion_r1521943289
##########
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexProviderService.java:
##########
@@ -104,201 +107,178 @@
import static
org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardUtils.scheduleWithFixedDelay;
@SuppressWarnings("UnusedDeclaration")
-@Component(metatype = true, label = "Apache Jackrabbit Oak
LuceneIndexProvider")
+@Component(property = { "enableCopyOnReadSupport:Boolean=true",
"enableCopyOnWriteSupport:Boolean=true" } )
Review Comment:
I would really recommend not mixing component property types with regular
properties. Just put the private properties to the Configuration annotation
type (but without the metatype annotations on the element). Also the default
values only need to be defined once then (and do no longer require a dedicated
constant) but can be added as literal on the component property type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
