stefan-egli commented on code in PR #1363:
URL: https://github.com/apache/jackrabbit-oak/pull/1363#discussion_r1547445759
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##########
@@ -352,7 +352,10 @@ private void applyToDocumentStore(RevisionVector
baseBranchRevision)
JournalEntry doc = JOURNAL.newDocument(store);
doc.modified(modifiedNodes);
Revision r = revision.asBranchRevision();
- store.create(JOURNAL, singletonList(doc.asUpdateOp(r)));
+ boolean success = store.create(JOURNAL,
singletonList(doc.asUpdateOp(r)));
+ if (!success) {
+ LOG.error("Failed to update journal for revision {}", r);
Review Comment:
It would have been the whole doc yes.
Alternatively, we could also do two logs : the existing LOG.error and an
additional LOG.debug with the doc... (such that it wouldn't log by default, but
it could be enabled)... (but I guess it's either way more of a detail)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
