nit0906 commented on code in PR #1398:
URL: https://github.com/apache/jackrabbit-oak/pull/1398#discussion_r1549144950


##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/NodeDocumentCodec.java:
##########
@@ -81,7 +81,12 @@ public NodeDocument decode(BsonReader reader, DecoderContext 
decoderContext) {
         while (reader.readBsonType() != BsonType.END_OF_DOCUMENT) {
             String fieldName = reader.readName();
             Object value = readValue(reader, fieldName);
-            nodeDocument.put(fieldName, value);
+            // Ignore hidden properties (property name starting with :)
+            // Hidden properties are not indexed and also ignored during async 
index updates.
+            // So it's safe to ignore them while building the FlatFileStore as 
well.
+            if (fieldName.charAt(0) != ':') {

Review Comment:
   makes sense.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to