reschke commented on code in PR #1426:
URL: https://github.com/apache/jackrabbit-oak/pull/1426#discussion_r1574321474


##########
oak-query-spi/src/main/java/org/apache/jackrabbit/oak/spi/query/QueryIndex.java:
##########
@@ -415,8 +430,20 @@ public Builder setDelayed(boolean isDelayed) {
                 return this;
             }
 
-            public Builder addAdditionalMessage(Level level, String s) {
-                this.additionalMessages.compute(level, (k,v) -> {
+            public Builder addAdditionalMessage(String level, String s) {

Review Comment:
   can we remove "public Builder addAdditionalMessage(Level level, String s)" 
right now? Don't we need an extra step deprecating it (and logging when it's 
used?). Or is this ok because the Builder class is not part of the API?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to