kwin commented on code in PR #334:
URL:
https://github.com/apache/jackrabbit-filevault/pull/334#discussion_r1576442352
##########
vault-core-it/vault-core-integration-tests/src/main/java/org/apache/jackrabbit/vault/packaging/integration/UserContentPackageIT.java:
##########
@@ -105,6 +105,15 @@ public void installUserA_Replace_PkgPath() throws
RepositoryException, IOExcepti
installUserA(ImportMode.REPLACE, true, true);
}
+ @Test
+ public void installUserA_Underscores() throws RepositoryException,
IOException, PackageException {
Review Comment:
For me this package this IT only proofs that the escaped filename
`_6k_LELiIYRQppWQpR3W` is correctly deescaped into `6k:LELiIYRQppWQpR3W`,
please try to come up with a test case which shows inconsistencies with a round
trip test.
##########
vault-core-it/vault-core-integration-tests/src/main/java/org/apache/jackrabbit/vault/packaging/integration/UserContentPackageIT.java:
##########
@@ -105,6 +105,15 @@ public void installUserA_Replace_PkgPath() throws
RepositoryException, IOExcepti
installUserA(ImportMode.REPLACE, true, true);
}
+ @Test
+ public void installUserA_Underscores() throws RepositoryException,
IOException, PackageException {
Review Comment:
For me this package/this IT only proofs that the escaped filename
`_6k_LELiIYRQppWQpR3W` is correctly deescaped into `6k:LELiIYRQppWQpR3W`,
please try to come up with a test case which shows inconsistencies with a round
trip test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
