nfsantos commented on code in PR #1437:
URL: https://github.com/apache/jackrabbit-oak/pull/1437#discussion_r1588873171
##########
oak-run/src/test/java/org/apache/jackrabbit/oak/index/IncrementalStoreTest.java:
##########
@@ -153,23 +156,48 @@ public void testWithGzipCompression() throws Exception {
// LZ4 compression is used by default - so disable that, fallback is
gzip
System.setProperty(OAK_INDEXER_USE_LZ4, "false");
algorithm = IndexStoreUtils.compressionAlgorithm();
- incrementalFFSTest(false);
+ incrementalFFSTest(false, false);
System.clearProperty(OAK_INDEXER_USE_LZ4);
}
@Test
public void testWithLz4Compression() throws Exception {
algorithm = IndexStoreUtils.compressionAlgorithm();
- incrementalFFSTest(false);
+ incrementalFFSTest(false, false);
}
@Test
public void testWithLz4CompressionWithCustomRegexFilter() throws Exception
{
-
System.setProperty("oak.indexer.pipelined.mongoCustomExcludeEntriesRegex",
+
System.setProperty(OAK_INDEXER_PIPELINED_MONGO_CUSTOM_EXCLUDE_ENTRIES_REGEX,
"(.*/jcr:content/renditions/foo\\.metadata\\.xml.*$)|(.*/jcr:content/renditions/foo\\.metadata\\..*$)|(.*/jcr:content/metadata/fooBar$)");
algorithm = IndexStoreUtils.compressionAlgorithm();
- incrementalFFSTest(true);
-
System.clearProperty("oak.indexer.pipelined.mongoCustomExcludeEntriesRegex");
+ incrementalFFSTest(true, false);
+
System.clearProperty(OAK_INDEXER_PIPELINED_MONGO_CUSTOM_EXCLUDE_ENTRIES_REGEX);
+ }
+
+ @Test
+ public void testWithLz4CompressionWithCustomExcludedPaths() throws
Exception {
+ System.setProperty(OAK_INDEXER_PIPELINED_MONGO_REGEX_PATH_FILTERING,
+ "true");
+ System.setProperty(OAK_INDEXER_PIPELINED_MONGO_CUSTOM_EXCLUDED_PATHS,
"/oak:index,/var/foo");
+ algorithm = IndexStoreUtils.compressionAlgorithm();
+ incrementalFFSTest(false, true);
+ System.clearProperty(OAK_INDEXER_PIPELINED_MONGO_REGEX_PATH_FILTERING);
+
System.clearProperty(OAK_INDEXER_PIPELINED_MONGO_CUSTOM_EXCLUDED_PATHS);
Review Comment:
You can use the following rule to clear system properties automatically. It
is used in other tests of the Pipelined strategy.
```
@Rule
public final RestoreSystemProperties restoreSystemProperties = new
RestoreSystemProperties();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
