nfsantos commented on code in PR #1435:
URL: https://github.com/apache/jackrabbit-oak/pull/1435#discussion_r1596821818


##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/NodeDocumentCodec.java:
##########
@@ -98,8 +99,7 @@ public Class<NodeDocument> getEncoderClass() {
         return NodeDocument.class;
     }
 
-    private Object readValue(BsonReader reader, String fieldName) {
-        estimatedSizeOfCurrentObject += 16 + fieldName.length();
+    private Object readValue(BsonReader reader, String fieldName, int[] 
estimatedSizeOfCurrentObject) {

Review Comment:
   I wanted to avoid creating a new class. But I agree it is not elegant. I 
have changed to use the MutableInt in Apache Commons, which is already in the 
classpath.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to