nfsantos commented on code in PR #1445:
URL: https://github.com/apache/jackrabbit-oak/pull/1445#discussion_r1597951110
##########
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/json/JsopBuilder.java:
##########
@@ -28,7 +28,7 @@ public class JsopBuilder implements JsopWriter {
private static final boolean JSON_NEWLINES = false;
- private StringBuilder buff = new StringBuilder();
+ private final StringBuilder buff = new StringBuilder();
Review Comment:
The field is not changed, so it should be final to convey the intention that
it should not change and to get the compiler to enforce this invariant. This
was causing a warning in IntelliJ and as it was in the same file that I was
modifying, I added this small improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
