daniancu commented on code in PR #1440:
URL: https://github.com/apache/jackrabbit-oak/pull/1440#discussion_r1598569082
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Configuration.java:
##########
@@ -311,10 +311,10 @@
@AttributeDefinition(
name = "Document Node Store Detailed GC",
description = "Boolean value indicating whether Detailed GC should
be enabled for " +
- "document node store or not. The Default value is " +
DEFAULT_DETAILED_GC_ENABLED +
+ "document node store or not. The Default value is " +
DEFAULT_FULL_GC_ENABLED +
". Note that this value can be overridden via framework " +
- "property 'oak.documentstore.detailedGCEnabled'")
- boolean detailedGCEnabled() default DEFAULT_DETAILED_GC_ENABLED;
+ "property 'oak.documentstore.fullGCEnabled'")
+ boolean fullGCEnabled() default DEFAULT_FULL_GC_ENABLED;
@AttributeDefinition(
name = "Document Node Store Embedded Verification for Detailed GC",
Review Comment:
fixed
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -748,23 +748,23 @@ private VersionGCStats gc(long maxRevisionAgeInMillis)
throws IOException {
collectSplitDocuments(phases, sweepRevisions, rec);
}
} else {
- phases.stats.detailedGCDryRunMode = true;
+ phases.stats.fullGCDryRunMode = true;
}
// now run detailed GC if enabled
- if (detailedGCEnabled) {
- stats.detailedGCActive.start();
- if (rec.ignoreDetailedGCDueToCheckPoint) {
- phases.stats.ignoredDetailedGCDueToCheckPoint = true;
+ if (fullGCEnabled) {
+ stats.fullGCActive.start();
+ if (rec.ignoreFullGCDueToCheckPoint) {
+ phases.stats.ignoredFullGCDueToCheckPoint = true;
monitor.skipped("Checkpoint prevented detailed
revision garbage collection");
} else {
final RevisionVector headRevision =
nodeStore.getHeadRevision();
- monitor.info("Looking at revisions in {} for detailed
GC", rec.scopeDetailedGC);
+ monitor.info("Looking at revisions in {} for detailed
GC", rec.scopeFullGC);
Review Comment:
fixed
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -850,9 +850,9 @@ protected boolean removeEldestEntry(Entry<Path, Boolean>
eldest) {
lastDoc = doc;
// collect the data to delete in next step
- if
(phases.start(GCPhase.DETAILED_GC_COLLECT_GARBAGE)) {
+ if
(phases.start(GCPhase.FULL_GC_COLLECT_GARBAGE)) {
gc.collectGarbage(doc, phases);
-
phases.stop(GCPhase.DETAILED_GC_COLLECT_GARBAGE);
+
phases.stop(GCPhase.FULL_GC_COLLECT_GARBAGE);
}
final Long modified = lastDoc.getModified();
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
