nit0906 commented on code in PR #1461:
URL: https://github.com/apache/jackrabbit-oak/pull/1461#discussion_r1602563040
##########
oak-store-spi/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeStateUtils.java:
##########
@@ -53,12 +52,7 @@ public static boolean isHidden(@NotNull String name) {
* @return true if one of the nodes is hidden
*/
public static boolean isHiddenPath(@NotNull String path) {
- for (String n : PathUtils.elements(path)) {
- if (isHidden(n)) {
- return true;
- }
- }
- return false;
+ return (!path.isEmpty() && path.charAt(0) == ':') ||
path.contains("/:");
Review Comment:
There's one behaviour change introduced by this PR - isHiddenPath no longer
checks if the path is valid or not. Earlier this used to happen when calling
PathUtils.elements.
This is not documented for this method, so in theory (might) be ok as well.
Otherwise the change looks ok to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
