reschke commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1628992660
##########
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java:
##########
@@ -33,11 +37,16 @@
import static org.apache.jackrabbit.guava.common.collect.Lists.newArrayList;
import static org.apache.jackrabbit.guava.common.collect.Sets.newHashSet;
-import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.*;
Review Comment:
no wildcard imports, please
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##########
@@ -160,14 +161,14 @@ String getValue() {
private String decompress(byte[] value) {
try {
- return new String(compression.getInputStream(new
ByteArrayInputStream(value)).readAllBytes());
+ return new String(compression.getInputStream(new
ByteArrayInputStream(value)).readAllBytes(), StandardCharsets.UTF_8);
} catch (IOException e) {
LOG.error("Failed to decompress property {} value: ", getName(),
e);
return "\"{}\"";
}
}
- public byte[] getCompressedValue() {
+ byte[] getCompressedValue() {
Review Comment:
Just in the test class? Can we avoid exposing it just that purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
