[ https://issues.apache.org/jira/browse/JCRVLT-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872062#comment-17872062 ]
Konrad Windszus commented on JCRVLT-767: ---------------------------------------- Even if {{Node.getIdentifer()}} is always non-null (and returns their path for non-referencable nodes) I don't see how the overall condition on the if would be wrong? Are you suggesting that stashing happens too often? I was assuming that stashing is necessary whenever we set the UUID (as we don't do tricks yet like removing the mixin to make the property unprotected). > vlt: potential incorrect identifier comparison > ---------------------------------------------- > > Key: JCRVLT-767 > URL: https://issues.apache.org/jira/browse/JCRVLT-767 > Project: Jackrabbit FileVault > Issue Type: Bug > Components: vlt > Reporter: Julian Reschke > Priority: Minor > > In > https://github.com/apache/jackrabbit-filevault/blob/931ceef98513167af3218b773d9213e123a2f52d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewImporter.java#L993-L1007 > {noformat} > if (identifier.isPresent() && > !node.getIdentifier().equals(identifier.get()) && > !"rep:root".equals(ni.getPrimaryType().orElse(""))) { > long startTime = System.currentTimeMillis(); > String previousIdentifier = node.getIdentifier(); > log.debug("Node stashing for {} starting, existing identifier: > {}, new identifier: {}, import mode: {}", > node.getPath(), previousIdentifier, identifier.get(), > importMode); > {noformat} > However, Node.getIdentifer() will always be non-null - even for nodes without > mix:referenceable. > This means that we go into stashing although we don't have to. -- This message was sent by Atlassian Jira (v8.20.10#820010)