kwin commented on code in PR #348:
URL: 
https://github.com/apache/jackrabbit-filevault/pull/348#discussion_r1711153105


##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewImporter.java:
##########
@@ -989,8 +989,19 @@ private void removeReferences(@NotNull Node node) throws 
ReferentialIntegrityExc
         VersioningState vs = new VersioningState(stack, node);
         Node updatedNode = null;
         Optional<String> identifier = ni.getIdentifier();
+
+        boolean isUuidProtected = false;
+        if (node.hasProperty(Property.JCR_UUID)) {
+            isUuidProtected = 
node.getProperty(Property.JCR_UUID).getDefinition().isProtected();
+        } else if (! 
session.getRepository().getDescriptor(Repository.REP_NAME_DESC).contains("Oak"))
 {

Review Comment:
   why else if? Shouldn't this also overwrite isUuidProtected from line 995 
potentially?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to