kwin commented on code in PR #350:
URL:
https://github.com/apache/jackrabbit-filevault/pull/350#discussion_r1721003243
##########
vault-core-it/vault-core-integration-tests/src/main/java/org/apache/jackrabbit/vault/packaging/integration/ReferenceableIdentifiersImportIT.java:
##########
@@ -418,28 +418,131 @@ public void testImportDupPolicyLegacy() throws
RepositoryException, IOException,
assertNull(duplicateNode);
}
+ // constants for behavior target state to be tested
+
+ private static enum TS {
+ CONFLICT_TARGET_MOVED, CONFLICT_TARGET_PRESENT,
NO_CONFLICT_TARGET_GONE, NO_CONFLICT_TARGET_UNCHANGED
+ };
+
+ // make boolean expectations readable
+
+ private static Boolean ID_NEW = true;
Review Comment:
why not encapsulating the semantics within the `enum TS`?
##########
vault-core-it/vault-core-integration-tests/src/main/java/org/apache/jackrabbit/vault/packaging/integration/ReferenceableIdentifiersImportIT.java:
##########
@@ -418,28 +418,131 @@ public void testImportDupPolicyLegacy() throws
RepositoryException, IOException,
assertNull(duplicateNode);
}
+ // constants for behavior target state to be tested
+
+ private static enum TS {
Review Comment:
I prefer a slightly longer name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
