[ 
https://issues.apache.org/jira/browse/JCRVLT-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907135#comment-17907135
 ] 

Konrad Windszus commented on JCRVLT-788:
----------------------------------------

I would think that just enriching the exception message in 
https://github.com/apache/jackrabbit-filevault/blob/367ffb423d84993c5bb0eb0186f810a58b6227be/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/config/DefaultWorkspaceFilter.java#L433
 with original mode value, converted to uppercase value and optionally default 
locale should be enough.
However there definitely is an issue here with Turkish locale (even if you are 
not affected currently), so fixing all issues being highlighted by 
https://github.com/apache/jackrabbit-filevault/pull/287 needs fixing by using 
the Locale.ROOT locale (in case one can be sure that only ASCII characters are 
used there).

> use of 'toUppercase' with default locale should be avoided
> ----------------------------------------------------------
>
>                 Key: JCRVLT-788
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-788
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>
> This may lead to surprising results, such as uppercasing "i" not resulting in 
> "I".
> See https://mattryall.net/blog/the-infamous-turkish-locale-bug



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to