[ https://issues.apache.org/jira/browse/JCRVLT-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934026#comment-17934026 ]
Julian Reschke commented on JCRVLT-789: --------------------------------------- bq. Julian Reschke I don't understand all implementation details of the DocumentNodeStore, and specifically I don't know if any document contains a list of all sub-documents (like the segment store), or if this list is computed dynamically. It's dynamic. bq. But anyway, I think that if we pass that regex down to lower layers, there is a chance to make use of that information, it would at least avoid the creation of unnecessary JCR nodes (for which you need to load dedicated documents in most situations). That we could get by a method that just returns the names. But yes, separate venue. > AggregateImpl might be able to avoid iterating over sibling nodes > ----------------------------------------------------------------- > > Key: JCRVLT-789 > URL: https://issues.apache.org/jira/browse/JCRVLT-789 > Project: Jackrabbit FileVault > Issue Type: Improvement > Components: vlt > Reporter: Julian Reschke > Assignee: Julian Reschke > Priority: Major > > See > [https://github.com/apache/jackrabbit-filevault/blob/367ffb423d84993c5bb0eb0186f810a58b6227be/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/AggregateImpl.java#L696] > > This code currently iterates unconditionally over child nodes (which is a > problem for large collections). We might be able to avoid that by checking > the filters before descending. > I tried a quick hack, and that made tests fail (which is good). > Will continue with a test case first. -- This message was sent by Atlassian Jira (v8.20.10#820010)